feat(pipeline): include triple count in import result reporting#217
Open
feat(pipeline): include triple count in import result reporting#217
Conversation
- Add optional tripleCount to ImportSuccessful (sparql-importer) - Parse num-triples from QLever container logs instead of reading metadata file from host filesystem (volume-agnostic) - Thread tripleCount through ResolvedDistribution and ProgressReporter - Display formatted triple count in console reporter, e.g. '✔ Imported …/file.nt (4.8M triples, to http://…) in 22.8s'
- Use regex instead of JSON.parse to extract num-triples from the metadata JSON that the index command cats to stdout - Docker log multiplexing prepends binary frame headers that corrupt JSON parsing; regex is resilient to these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tripleCountproperty toImportSuccessfulso importers can report how many triples were indexed.cat <metadata>.jsonto the index command and parsesnum-triples.normalfrom the container logs using a regex (resilient to Docker log multiplexing binary frame headers). No host filesystem access needed.tripleCountthroughResolvedDistribution→ProgressReporter→ConsoleReporter.✔ Imported …/file.nt (4.8M triples, to http://…) in 22.8s.